Fix | Fix SharedTimer implementation to use class level lock for thread safety#1046
Merged
cheenamalhotra merged 3 commits intomicrosoft:devfrom May 15, 2019
Merged
Conversation
eugeniyk
reviewed
Apr 24, 2019
sehrope
reviewed
Apr 24, 2019
sehrope
reviewed
Apr 24, 2019
sehrope
reviewed
Apr 24, 2019
Contributor
|
The static |
Contributor
|
Actually maybe it doesn't need the explicit synchronized lock at all as it's accessing the volatile field. The method level synchronized can be removed though as the only thing it would be synchronizing is concurrent callers to that one method. |
peterbae
approved these changes
Apr 25, 2019
lilgreenbird
approved these changes
Apr 30, 2019
rene-ye
approved these changes
May 10, 2019
ulvii
reviewed
May 14, 2019
ulvii
reviewed
May 14, 2019
ulvii
reviewed
May 14, 2019
ulvii
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1040