Add formatErrorMsg for comparing error messages in tests#1034
Merged
lilgreenbird merged 10 commits intomicrosoft:devfrom Apr 24, 2019
Merged
Add formatErrorMsg for comparing error messages in tests#1034lilgreenbird merged 10 commits intomicrosoft:devfrom
lilgreenbird merged 10 commits intomicrosoft:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1034 +/- ##
============================================
+ Coverage 50.81% 50.81% +<.01%
+ Complexity 2966 2963 -3
============================================
Files 120 120
Lines 28001 27940 -61
Branches 4686 4675 -11
============================================
- Hits 14228 14199 -29
+ Misses 11618 11591 -27
+ Partials 2155 2150 -5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## dev #1034 +/- ##
============================================
+ Coverage 50.83% 50.84% +0.01%
- Complexity 2964 2967 +3
============================================
Files 120 120
Lines 28001 27952 -49
Branches 4686 4675 -11
============================================
- Hits 14233 14213 -20
+ Misses 11616 11584 -32
- Partials 2152 2155 +3
Continue to review full report at Codecov.
|
cheenamalhotra
previously approved these changes
Apr 16, 2019
ulvii
previously approved these changes
Apr 16, 2019
rene-ye
previously approved these changes
Apr 16, 2019
peterbae
reviewed
Apr 17, 2019
peterbae
reviewed
Apr 17, 2019
peterbae
reviewed
Apr 17, 2019
lilgreenbird
dismissed stale reviews from rene-ye, ulvii, and cheenamalhotra
via
6a970e0
rene-ye
reviewed
Apr 23, 2019
ulvii
reviewed
Apr 23, 2019
rene-ye
reviewed
Apr 23, 2019
rene-ye
reviewed
Apr 23, 2019
rene-ye
reviewed
Apr 23, 2019
ulvii
reviewed
Apr 23, 2019
cheenamalhotra
approved these changes
Apr 24, 2019
rene-ye
approved these changes
Apr 24, 2019
ulvii
approved these changes
Apr 24, 2019
peterbae
reviewed
Apr 24, 2019
| } else { | ||
| timeoutUnitInterval = timerTimeout; | ||
| } | ||
| timeoutUnitInterval = (isDBMirroring || useParallel) ? (long) (TIMEOUTSTEP * timerTimeout) |
Contributor
There was a problem hiding this comment.
Why do we need to do this? This impacts readability a lot.
peterbae
reviewed
Apr 24, 2019
| static int timerRemaining(long timerExpire) { | ||
| long remaining = timerExpire - System.currentTimeMillis(); | ||
| // maximum timeout the socket takes is int max, minimum is at least 1 ms | ||
| return (int) ((remaining > Integer.MAX_VALUE) ? Integer.MAX_VALUE : (remaining <= 0) ? 1 : remaining); |
peterbae
reviewed
Apr 24, 2019
| fedAuthRequiredByUser = true; | ||
| } | ||
|
|
||
| fedAuthRequiredByUser = (!authenticationString.equalsIgnoreCase(SqlAuthentication.NotSpecified.toString())) |
Contributor
There was a problem hiding this comment.
Why was this line added? it looks like a duplicate of line 2436?
peterbae
reviewed
Apr 24, 2019
peterbae
approved these changes
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
formatErrorMsg() from @rene-ye