Skip to content

Tests | Move Exclude Groups to Constants and finalize them#1032

Merged
cheenamalhotra merged 4 commits intomicrosoft:devfrom
cheenamalhotra:constants
Apr 12, 2019
Merged

Tests | Move Exclude Groups to Constants and finalize them#1032
cheenamalhotra merged 4 commits intomicrosoft:devfrom
cheenamalhotra:constants

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

@cheenamalhotra cheenamalhotra commented Apr 11, 2019

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 11, 2019 •
edited
Loading

Codecov Report

Merging #1032 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               dev    #1032      +/-   ##
===========================================
+ Coverage     50.8%   50.82%   +0.02%     
+ Complexity    2963     2962       -1     
===========================================
  Files          120      120              
  Lines        27994    28001       +7     
  Branches      4683     4686       +3     
===========================================
+ Hits         14221    14232      +11     
+ Misses       11620    11618       -2     
+ Partials      2153     2151       -2
Flag Coverage Δ Complexity Δ
#JDBC42 50.38% <ø> (+0.01%) 2926 <ø> (ø) ⬇️
#JDBC43 50.7% <ø> (+0.02%) 2955 <ø> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 55.97% <0%> (-1.5%) 15% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 63.36% <0%> (-0.44%) 95% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.83% <0%> (-0.39%) 322% <0%> (-5%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.53% <0%> (+0.17%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.13% <0%> (+0.2%) 63% <0%> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.64%) 43% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 66.95% <0%> (+0.83%) 164% <0%> (+5%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java 70.24% <0%> (+1.28%) 0% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.25% <0%> (+3.29%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 727efcc...16f9875. Read the comment docs.

peterbae
peterbae previously approved these changes Apr 11, 2019
View reviewed changes
@cheenamalhotra cheenamalhotra merged commit e1f3d7e into microsoft:dev Apr 12, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@rene-ye rene-ye rene-ye approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@ulvii ulvii ulvii approved these changes

@peterbae peterbae peterbae approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.3.1

Development

Successfully merging this pull request may close these issues.

6 participants

@cheenamalhotra @codecov-io @rene-ye @lilgreenbird @ulvii @peterbae