Skip to content

Tests | Fix LobsStreamingTest to close all streams and resources appropriately#1019

Merged
cheenamalhotra merged 1 commit intomicrosoft:devfrom
cheenamalhotra:lobsStreamingTest
Apr 3, 2019
Merged

Tests | Fix LobsStreamingTest to close all streams and resources appropriately#1019
cheenamalhotra merged 1 commit intomicrosoft:devfrom
cheenamalhotra:lobsStreamingTest

Conversation

@cheenamalhotra
Copy link
Copy Markdown
Member

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 3, 2019

Codecov Report

Merging #1019 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1019      +/-   ##
============================================
+ Coverage     50.16%   50.18%   +0.01%     
  Complexity     2885     2885              
============================================
  Files           120      120              
  Lines         27989    27989              
  Branches       4677     4677              
============================================
+ Hits          14040    14045       +5     
+ Misses        11693    11687       -6     
- Partials       2256     2257       +1
Flag Coverage Δ Complexity Δ
#JDBC42 49.69% <ø> (-0.01%) 2839 <ø> (-4)
#JDBC43 50.09% <ø> (+0.03%) 2881 <ø> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 62.5% <0%> (-0.44%) 91% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.22%) 43% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.55% <0%> (+0.06%) 0% <0%> (ø) ⬇️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.3% <0%> (+0.43%) 112% <0%> (+1%) ⬆️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 60.94% <0%> (+1.18%) 35% <0%> (+1%) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 47.25% <0%> (+2.19%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a64e479...d998fbc. Read the comment docs.

@cheenamalhotra cheenamalhotra requested a review from rene-ye April 3, 2019 20:12
@cheenamalhotra cheenamalhotra merged commit caddd83 into microsoft:dev Apr 3, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.1 milestone Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants