Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .tsbuildinfo to build with tsc and tsc --w when not using build mode #30232

Merged
merged 7 commits into from
Mar 9, 2019

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented Mar 5, 2019

Works on top of #29813
This change should help with #12996

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Mar 5, 2019

@RyanCavanaugh @rbuckton @DanielRosenwasser This change is on top of tsc --b generating .tsbuildinfo. The main change is that tsc --w will use the hash as file version instead of count of changes in lifetime of the span (as otherwise the written signature makes no sense in determining if the file has changed and technically we want all tsc modes to use same version type so its compatible in all modes?).
Its ready for review as well.

@sheetalkamat
Copy link
Member Author

@RyanCavanaugh please take a look at this as well since I think having same file version when writing tsbuildinfo is important for things to work correctly and because we don't have published API for tsbuild yet many apis depend on watch api to build the projects and we should not regress there by writing conflicting file versions.

@sheetalkamat sheetalkamat changed the base branch from incrementalBuildInfo to master March 8, 2019 23:50
@sheetalkamat sheetalkamat force-pushed the incrementalWithNormalTsc branch from 82024e2 to f82cb23 Compare March 9, 2019 00:36
@sheetalkamat sheetalkamat merged commit 409e076 into master Mar 9, 2019
@sheetalkamat sheetalkamat deleted the incrementalWithNormalTsc branch March 9, 2019 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants