Add basic test for speech recognition and synthesis#2153
Merged
compulim merged 25 commits intomicrosoft:masterfrom Jul 9, 2019
Merged
Add basic test for speech recognition and synthesis#2153compulim merged 25 commits intomicrosoft:masterfrom
compulim merged 25 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
approved these changes
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2122.
Changelog Entry
Description
Speech recognition and synthesis in Web Chat is not tested due to lack of test harness.
This work will add test harness so we can start testing speech functionality in Web Chat, along with basic tests for speech.
This work does not modify any production code.
Specific Changes
mockWebSpeech.jswhile loading the test harness pagewindow.WebSpeechMockfor required ponyfills and mock functions