Fixed AdaptiveCards Update Issues#2075
Merged
tdurnford merged 16 commits intomicrosoft:masterfrom Jun 17, 2019
Merged
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
compulim
approved these changes
Jun 12, 2019
Contributor
compulim
left a comment
compulim
left a comment
There was a problem hiding this comment.
Looks good.
If my only comment is not correct, please just commit.
If my only comment is correct, please fix and commit.
So, either way, I approve. 😄
Contributor
|
🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2068
Fix #2068. Fixed AdaptiveCards validate and speak issues, by @tdurnford in PR #2075
Specific Changes
Changed
CardObject.validate()toCardObject.validateProperties()in the AdaptiveCardRenderer component per AdaptiveCard's breaking-changes documentation. Also modified how the AdaptiveCardBuilder class handles speaking text since the speak attribute was removed from TextBlocks in the newest version of AdaptiveCards.