Should not stop after first spoken text#2016
Merged
compulim merged 3 commits intomicrosoft:masterfrom May 22, 2019
Merged
Conversation
corinagum
approved these changes
May 21, 2019
Contributor
Author
|
@darrenj yes, this one is related. The bug this PR will fix is, "when we finish speaking any activities, we will start dictating and stop speaking." Instead of "any", it should be "all". That's the bug. The other bug about "cut off" or "not talking at all", is #1829. What I believe is:
So that's why if the text is too long, you may or may not able to hear it. Working on it now. |
1 task
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1736.
Changelog Entry
Description
In
startDictateAfterSpeakActivitySaga, we are using a wrong selector.Originally, we want to check if "all activities are spoken", but since we used a wrong selector, we was checking "if the currently speaking activity is spoken". And of course it is, because we just set a flag on it.
Specific Changes
Testing Added