Sample: Single-sign on for enterprise app#2002
Merged
compulim merged 120 commits intomicrosoft:masterfrom Jun 19, 2019
Merged
Conversation
compulim
changed the title
corinagum
suggested changes
May 20, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
I think at the very least all of the .js files should have a short comment at the top explaining what it's doing, since this is a sample.
I'm going to try implementing this now and let you know if I have more feedback
corinagum
reviewed
May 20, 2019
corinagum
reviewed
May 20, 2019
corinagum
reviewed
May 20, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
corinagum
reviewed
May 22, 2019
Contributor
|
can you also run |
Contributor
Author
|
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
justinwilaby and
tonyanziano
as code owners
corinagum
approved these changes
Jun 19, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Very thorough! LGTM :)
…ex.html Co-Authored-By: Corina <[email protected]>
…ex.html Co-Authored-By: Corina <[email protected]>
…Profile/Composer.js Co-Authored-By: Corina <[email protected]>
…rosoftGraphProfileMenu.js Co-Authored-By: Corina <[email protected]>
…Profile/Composer.js Co-Authored-By: Corina <[email protected]>
…ex.html Co-Authored-By: Corina <[email protected]>
…oftGraphProfile/Composer.js Co-Authored-By: Corina <[email protected]>
…Bot.js Co-Authored-By: Corina <[email protected]>
…Bot.js Co-Authored-By: Corina <[email protected]>
…tils/generateOAuthState.js Co-Authored-By: Corina <[email protected]>
…ndex.js Co-Authored-By: Corina <[email protected]>
…oftGraphProfile/fetchProfilePhotoAsBase64.js Co-Authored-By: Corina <[email protected]>
…Composer.js Co-Authored-By: Corina <[email protected]>
…Composer.js Co-Authored-By: Corina <[email protected]>
…Composer.js Co-Authored-By: Corina <[email protected]>
…HubProfileMenu.js Co-Authored-By: Corina <[email protected]>
…HubProfileMenu.js Co-Authored-By: Corina <[email protected]>
…HubProfileMenu.js Co-Authored-By: Corina <[email protected]>
…HubProfileMenu.js Co-Authored-By: Corina <[email protected]>
…HubProfileMenu.js Co-Authored-By: Corina <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1564.
Changelog Entry
*: Single-sign on for enterprise apps, in #2002Description
Added a sample for "Single sign-on for enterprise apps using OAuth".
Specific Changes
/samples/19.a.single-sign-on-for-enterprise-apps