Skip to content

Fix create style set with ac#1987

Merged
corinagum merged 6 commits intomicrosoft:masterfrom
corinagum:fix-createStyleSetWithAC
May 15, 2019
Merged

Fix create style set with ac#1987
corinagum merged 6 commits intomicrosoft:masterfrom
corinagum:fix-createStyleSetWithAC

Conversation

@corinagum
Copy link
Copy Markdown
Contributor

@corinagum corinagum commented May 14, 2019

Fixes #1969

Changelog Entry

Description

Because Adaptive Cards have been moved to the full bundle, the styleSets also need to be moved. I missed this on the original PR.

  • Testing Added

Copy link
Copy Markdown
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread packages/bundle/src/FullReactWebChat.js
Comment thread packages/bundle/src/FullReactWebChat.js Outdated
Comment thread packages/bundle/src/FullReactWebChat.js Outdated
Comment thread packages/bundle/src/FullReactWebChat.js Outdated
Comment thread packages/bundle/src/FullReactWebChat.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/adaptiveCardHostConfig.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/createStyleSetWithAdaptiveCards.spec.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/createStyleSetWithAdaptiveCards.spec.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/createStyleSetWithAdaptiveCards.spec.js Outdated
Comment thread packages/bundle/src/adaptiveCards/Styles/createStyleSetWithAdaptiveCards.spec.js Outdated
@corinagum corinagum merged commit 24672f7 into microsoft:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move styleSet related to Adaptive Cards and rich cards to full bundle

2 participants