Skip to content

Fix suggested actions scroll bar in Firefox and removes gaps#1953

Merged
corinagum merged 8 commits intomicrosoft:masterfrom
compulim:fix-firefox-suggested-actions
May 2, 2019
Merged

Fix suggested actions scroll bar in Firefox and removes gaps#1953
corinagum merged 8 commits intomicrosoft:masterfrom
compulim:fix-firefox-suggested-actions

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented May 2, 2019

Fix #1947 and #1952.

Few things changed:

  • Adds scrollbar-width: none to suggested actions carousel
    • Firefox did not support customizing scrollbar width until 64. Current version is 66. So it meet our "minus 2 versions" bar just recently
  • Moves from CSS selector to style set while we are using react-film
  • Removes gaps around suggested actions

Changelog

Fixed

  • Fix #1947. Fix scrollbar in suggested action should be hidden in Firefox, remove gaps, and use style set for customizing react-film, by @compulim in PR #1953

@compulim compulim force-pushed the fix-firefox-suggested-actions branch from 40efb16 to 20726d8 Compare May 2, 2019 02:18
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 57.791% when pulling 20726d8 on compulim:fix-firefox-suggested-actions into 98c662f on Microsoft:master.

@compulim compulim added the 4.4 label May 2, 2019
@corinagum corinagum merged commit 6f67e58 into microsoft:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested actions produce unnecessary horizontal scroll bar in Firefox

3 participants