Fix carousel alignment and test perf improvement#1641
Merged
compulim merged 10 commits intomicrosoft:masterfrom Jan 28, 2019
Merged
Fix carousel alignment and test perf improvement#1641compulim merged 10 commits intomicrosoft:masterfrom
compulim merged 10 commits intomicrosoft:masterfrom
Conversation
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
Contributor
|
Partial fix for #1625 |
corinagum
reviewed
Jan 25, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Let's get your two pending PR's in before we worry about this one.
corinagum
approved these changes
Jan 28, 2019
Contributor
corinagum
left a comment
corinagum
left a comment
There was a problem hiding this comment.
Pending a question and minor CHANGELOG.md fix :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Alignment was broken due to #1560 and #1561 when showing carousel with bot avatar initials.
This PR will also add tests for carousel and stacked layout, and a bit more stuff:
hideCursorconstants.jsonAll tests running locally on my box took 49 seconds.
Changelog
Fixed
component: Fix #1560 and #1635. Fixed carousel layout did not show date and alignment issues, by @compulim in PR #1561 and #1641