Skip to content

Hide upload button thru style options#1491

Merged
compulim merged 3 commits intomicrosoft:masterfrom
compulim:feat-hide-upload-button
Dec 13, 2018
Merged

Hide upload button thru style options#1491
compulim merged 3 commits intomicrosoft:masterfrom
compulim:feat-hide-upload-button

Conversation

@compulim
Copy link
Copy Markdown
Contributor

@compulim compulim commented Dec 13, 2018

Fix #1383

Background

This work will hide the file upload button from send box UI. It will not affect the file upload functionality if triggered via other means, e.g. via React context or Redux store.

When specified thru styleOptions.hideUploadButton, send box UI will not display upload button.

Changelog

Added

Samples

@compulim compulim added the 4.3 label Dec 13, 2018
@compulim compulim added this to the v4.3 milestone Dec 13, 2018
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 601

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 44.697%

Totals Coverage Status
Change from base Build 598: 0.05%
Covered Lines: 715
Relevant Lines: 1426

💛 - Coveralls

@a-b-r-o-w-n a-b-r-o-w-n self-requested a review December 13, 2018 17:14
@compulim compulim merged commit 5ff1608 into microsoft:master Dec 13, 2018
@compulim compulim deleted the feat-hide-upload-button branch December 13, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants