fix: Allow readonly string[] for Subscription topics#718
Closed
robhogan wants to merge 2 commits intoMichalLytek:masterfrom
Closed
fix: Allow readonly string[] for Subscription topics#718robhogan wants to merge 2 commits intoMichalLytek:masterfrom
readonly string[] for Subscription topics#718robhogan wants to merge 2 commits intoMichalLytek:masterfrom
Conversation
MichalLytek
requested changes
Oct 6, 2020
Owner
MichalLytek
left a comment
MichalLytek
left a comment
There was a problem hiding this comment.
Please try to reproduce the error in tests, push the failing commit and then after CI fail push the fixing commit.
MichalLytek
added
Community 👨👧
Author
|
Ach, looks like the issue starts upstream in Thanks for the quick response anyway, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran into this while attempting to pass something like
['Topic1', 'Topic2'] as constto subscription options - there's no reason to restrict to mutable arrays here.