Repository navigation
Commit f70f808
committed
Make overloads respect keyword-only args
This commit resolves python#1907.
Specifically, it turned out that support for non-positional args in
overload was never implemented to begin with. Thankfully, it also turned
out the bulk of the logic we wanted was already implemented within
`mypy.subtypes.is_callable_subtype`. Rather then re-implementing that
code, this commit refactors that method to support any kind of check,
instead of specifically subtype checks.
This, as a side-effect, ended up making some partial progress towards
python#4159 -- this is because unlike
the existing checks, `mypy.subtypes.is_callable_subtype` *doesn't* erase
types and has better support for typevars in general.
The reason this commit does not fully remove type erasure from overload
checks is because the new implementation still calls
`mypy.meet.is_overlapping_types` which *does* perform erasure. But
fixing that seemed out-of-scope for this commit, so I stopped here.1 parent a2fd962 commit f70f808
5 files changed
Lines changed: 139 additions & 90 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
437 | 437 | | |
438 | 438 | | |
439 | 439 | | |
440 | | - | |
| 440 | + | |
| 441 | + | |
441 | 442 | | |
442 | 443 | | |
443 | 444 | | |
| |||
3524 | 3525 | | |
3525 | 3526 | | |
3526 | 3527 | | |
3527 | | - | |
3528 | | - | |
3529 | | - | |
3530 | 3528 | | |
| 3529 | + | |
3531 | 3530 | | |
3532 | 3531 | | |
3533 | | - | |
| 3532 | + | |
3534 | 3533 | | |
3535 | 3534 | | |
3536 | 3535 | | |
3537 | | - | |
3538 | | - | |
3539 | | - | |
3540 | | - | |
3541 | | - | |
3542 | | - | |
3543 | | - | |
| 3536 | + | |
| 3537 | + | |
| 3538 | + | |
| 3539 | + | |
| 3540 | + | |
| 3541 | + | |
| 3542 | + | |
| 3543 | + | |
| 3544 | + | |
| 3545 | + | |
| 3546 | + | |
| 3547 | + | |
3544 | 3548 | | |
3545 | 3549 | | |
3546 | 3550 | | |
3547 | 3551 | | |
3548 | 3552 | | |
| 3553 | + | |
3549 | 3554 | | |
3550 | 3555 | | |
3551 | 3556 | | |
3552 | 3557 | | |
| 3558 | + | |
3553 | 3559 | | |
3554 | | - | |
3555 | | - | |
3556 | | - | |
| 3560 | + | |
| 3561 | + | |
| 3562 | + | |
3557 | 3563 | | |
| 3564 | + | |
| 3565 | + | |
| 3566 | + | |
3558 | 3567 | | |
3559 | 3568 | | |
3560 | 3569 | | |
| |||
3563 | 3572 | | |
3564 | 3573 | | |
3565 | 3574 | | |
3566 | | - | |
3567 | 3575 | | |
3568 | 3576 | | |
3569 | | - | |
3570 | | - | |
3571 | | - | |
| 3577 | + | |
| 3578 | + | |
| 3579 | + | |
3572 | 3580 | | |
3573 | 3581 | | |
3574 | 3582 | | |
| |||
3577 | 3585 | | |
3578 | 3586 | | |
3579 | 3587 | | |
3580 | | - | |
3581 | | - | |
3582 | | - | |
3583 | | - | |
3584 | | - | |
3585 | | - | |
3586 | | - | |
3587 | | - | |
3588 | | - | |
3589 | | - | |
3590 | | - | |
3591 | | - | |
3592 | | - | |
3593 | | - | |
3594 | | - | |
3595 | | - | |
3596 | | - | |
3597 | | - | |
3598 | | - | |
3599 | | - | |
3600 | | - | |
3601 | | - | |
3602 | | - | |
3603 | 3588 | | |
3604 | 3589 | | |
3605 | 3590 | | |
| |||
3615 | 3600 | | |
3616 | 3601 | | |
3617 | 3602 | | |
3618 | | - | |
3619 | | - | |
3620 | | - | |
| 3603 | + | |
| 3604 | + | |
| 3605 | + | |
| 3606 | + | |
| 3607 | + | |
3621 | 3608 | | |
3622 | 3609 | | |
3623 | 3610 | | |
3624 | 3611 | | |
3625 | 3612 | | |
3626 | 3613 | | |
3627 | 3614 | | |
3628 | | - | |
3629 | | - | |
3630 | | - | |
3631 | 3615 | | |
3632 | | - | |
3633 | | - | |
3634 | | - | |
3635 | | - | |
3636 | | - | |
3637 | | - | |
| 3616 | + | |
| 3617 | + | |
| 3618 | + | |
3638 | 3619 | | |
3639 | 3620 | | |
3640 | 3621 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
525 | 525 | | |
526 | 526 | | |
527 | 527 | | |
528 | | - | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
529 | 531 | | |
530 | 532 | | |
531 | 533 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
203 | 203 | | |
204 | 204 | | |
205 | 205 | | |
206 | | - | |
| 206 | + | |
207 | 207 | | |
| 208 | + | |
208 | 209 | | |
209 | 210 | | |
210 | 211 | | |
| |||
310 | 311 | | |
311 | 312 | | |
312 | 313 | | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
317 | 320 | | |
318 | 321 | | |
319 | 322 | | |
| |||
568 | 571 | | |
569 | 572 | | |
570 | 573 | | |
571 | | - | |
572 | | - | |
573 | | - | |
574 | | - | |
575 | | - | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
576 | 581 | | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
581 | 590 | | |
582 | 591 | | |
583 | 592 | | |
| |||
610 | 619 | | |
611 | 620 | | |
612 | 621 | | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
613 | 625 | | |
614 | 626 | | |
615 | 627 | | |
| |||
664 | 676 | | |
665 | 677 | | |
666 | 678 | | |
667 | | - | |
| 679 | + | |
668 | 680 | | |
669 | 681 | | |
670 | 682 | | |
| |||
687 | 699 | | |
688 | 700 | | |
689 | 701 | | |
690 | | - | |
| 702 | + | |
691 | 703 | | |
692 | 704 | | |
693 | 705 | | |
| |||
696 | 708 | | |
697 | 709 | | |
698 | 710 | | |
699 | | - | |
| 711 | + | |
700 | 712 | | |
701 | 713 | | |
702 | 714 | | |
| |||
748 | 760 | | |
749 | 761 | | |
750 | 762 | | |
751 | | - | |
| 763 | + | |
752 | 764 | | |
753 | 765 | | |
754 | 766 | | |
| |||
759 | 771 | | |
760 | 772 | | |
761 | 773 | | |
762 | | - | |
763 | | - | |
764 | | - | |
765 | | - | |
766 | | - | |
767 | | - | |
| 774 | + | |
| 775 | + | |
768 | 776 | | |
769 | 777 | | |
770 | 778 | | |
771 | 779 | | |
772 | 780 | | |
773 | 781 | | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
774 | 788 | | |
775 | 789 | | |
776 | 790 | | |
| |||
913 | 927 | | |
914 | 928 | | |
915 | 929 | | |
916 | | - | |
917 | | - | |
918 | | - | |
919 | | - | |
| 930 | + | |
920 | 931 | | |
921 | 932 | | |
922 | 933 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
789 | 789 | | |
790 | 790 | | |
791 | 791 | | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
792 | 799 | | |
793 | 800 | | |
794 | 801 | | |
| |||
0 commit comments