Feature/174/implement clone for make allow all authenticator#179
Merged
tofay merged 2 commits intoMetaswitch:masterfrom Jun 10, 2025
Conversation
azriel-healthpoint
force-pushed
the
feature/174/implement-clone-for-make-allow-all-authenticator
branch
from
7397975 to
e11251e
Compare
5 tasks
dsteeley
approved these changes
Jun 10, 2025
Contributor
dsteeley
left a comment
dsteeley
left a comment
There was a problem hiding this comment.
Thanks for contributing this.
Signed-off-by: Azriel Hoh <[email protected]>
Signed-off-by: Azriel Hoh <[email protected]>
tofay
force-pushed
the
feature/174/implement-clone-for-make-allow-all-authenticator
branch
from
e11251e to
7898b2e
Compare
azriel-healthpoint
deleted the
feature/174/implement-clone-for-make-allow-all-authenticator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya, I was trying to get the OpenAPI
rust-servergenerator to usehyper 1.6, and one of the parts needed for that to work is to pass in ahyper::service::Serviceto an async closure, which requires the closure to be'static.Because the passed in
servicecannot be borrowed (which would make it not'static), either it would have to be constructed on each call, orclone()d. For cloning to work,MakeAllowAllAuthenticatorneeds to implClone, which I've done here.