feat: adding mobile wallet protocol#1346
Merged
Merged
Conversation
…rage and refactor node
8f67cca to
56541c3
Compare
c254e5a to
6b611d3
Compare
chakra-guy
reviewed
Sep 17, 2025
chakra-guy
reviewed
Sep 17, 2025
chakra-guy
reviewed
Sep 17, 2025
chakra-guy
reviewed
Sep 17, 2025
chakra-guy
reviewed
Sep 17, 2025
chakra-guy
reviewed
Sep 17, 2025
chakra-guy
reviewed
Sep 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 74.93% 74.93%
=======================================
Files 184 184
Lines 4513 4513
Branches 1105 1105
=======================================
Hits 3382 3382
Misses 1131 1131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
chakra-guy
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
Implementing mobile wallet protocol compatibility with the SDK.
1. Changes in Storage
The Node storage no longer uses FS, instead it became inMemory plus the SDK can now be instantiated by providing a custom storage client.
2. Integrate MWP protocol into Modal factory
Modal factory multi-platform abstraction, allows us to manage modals on node, web and react-native apps.
Added new parameters to manage UI modals which now can trigger a new MWP sessionRequest creation.
3. Integrate MWP into multichain SDK
We first created a new MWPTransport which will be know connecting to the new relay server.
The Multichain SDK will then decide what action to take, restoring a previously saved connection + transport or use installModal to expect connecting MWP at some point or seeing the user close the modal manually.
4. Wait for initial connection on InstallModal
Install modal will require a QRCode, sessionRequest for mobile wallet protocol to be scanned later on to establish a real connection with a device.
There's literally a multichain-api, Transport for mobile wallet protocol. The transport is called once the Install Modal is ready to show. The connection process will then emit a new sessionRequest that we can capture and show as QRCode.
Upon a successful connection with the transport, the install modal automatically closes and the connection method resolves with void for now.
References
Checklist