Skip to content

feat: adding mobile wallet protocol#1346

Merged
elribonazo merged 18 commits into
mainfrom
features/multichain-mwp
Sep 17, 2025
Merged

feat: adding mobile wallet protocol#1346
elribonazo merged 18 commits into
mainfrom
features/multichain-mwp

Conversation

@elribonazo
Copy link
Copy Markdown
Contributor

@elribonazo elribonazo commented Sep 15, 2025

Explanation

Implementing mobile wallet protocol compatibility with the SDK.

1. Changes in Storage

The Node storage no longer uses FS, instead it became inMemory plus the SDK can now be instantiated by providing a custom storage client.

2. Integrate MWP protocol into Modal factory

Modal factory multi-platform abstraction, allows us to manage modals on node, web and react-native apps.

Added new parameters to manage UI modals which now can trigger a new MWP sessionRequest creation.

3. Integrate MWP into multichain SDK

We first created a new MWPTransport which will be know connecting to the new relay server.

The Multichain SDK will then decide what action to take, restoring a previously saved connection + transport or use installModal to expect connecting MWP at some point or seeing the user close the modal manually.

4. Wait for initial connection on InstallModal

Install modal will require a QRCode, sessionRequest for mobile wallet protocol to be scanned later on to establish a real connection with a device.

There's literally a multichain-api, Transport for mobile wallet protocol. The transport is called once the Install Modal is ready to show. The connection process will then emit a new sessionRequest that we can capture and show as QRCode.

Upon a successful connection with the transport, the install modal automatically closes and the connection method resolves with void for now.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@elribonazo elribonazo force-pushed the features/multichain-mwp branch from 8f67cca to 56541c3 Compare September 15, 2025 12:49
@elribonazo elribonazo marked this pull request as ready for review September 15, 2025 13:05
@elribonazo elribonazo requested a review from a team as a code owner September 15, 2025 13:05
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@elribonazo elribonazo force-pushed the features/multichain-mwp branch from c254e5a to 6b611d3 Compare September 16, 2025 15:04
cursor[bot]

This comment was marked as outdated.

Comment thread packages/sdk-multichain-ui/src/components/test.svg Outdated
Comment thread packages/sdk-multichain-ui/src/components.d.ts
Comment thread packages/sdk-multichain-ui/src/components.d.ts
Comment thread packages/sdk-multichain/src/multichain/mwp/index.ts
Comment thread packages/sdk-multichain/src/multichain/mwp/index.ts
Comment thread packages/sdk-multichain/package.json
Comment thread packages/sdk-multichain/package.json
chakra-guy
chakra-guy previously approved these changes Sep 17, 2025
Copy link
Copy Markdown
Collaborator

@chakra-guy chakra-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@elribonazo elribonazo enabled auto-merge (squash) September 17, 2025 14:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.93%. Comparing base (7eb3e16) to head (bcfd879).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1346   +/-   ##
=======================================
  Coverage   74.93%   74.93%           
=======================================
  Files         184      184           
  Lines        4513     4513           
  Branches     1105     1105           
=======================================
  Hits         3382     3382           
  Misses       1131     1131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@elribonazo elribonazo merged commit 26005b4 into main Sep 17, 2025
42 checks passed
@elribonazo elribonazo deleted the features/multichain-mwp branch September 17, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants