chore: pin debug package to exact version due to npm compromise#1342
Merged
dylanbutler1 merged 2 commits intomainfrom Sep 9, 2025
Merged
chore: pin debug package to exact version due to npm compromise#1342dylanbutler1 merged 2 commits intomainfrom
debug package to exact version due to npm compromise#1342dylanbutler1 merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
=======================================
Coverage 74.93% 74.93%
=======================================
Files 184 184
Lines 4513 4513
Branches 1105 1105
=======================================
Hits 3382 3382
Misses 1131 1131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
adonesky1
approved these changes
Sep 9, 2025
adonesky1
approved these changes
Sep 9, 2025
dylanbutler1
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The author of the
debugpackage had their account compromised and the attacker published code in this package on version4.4.2. This PR updates pins this dependency to4.3.4exactly, without accepting minor version bumps.While the MetaMask SDK wasn't directly impacted by this supply chain attack, users of the SDK may have downloaded affected versions of these packages.
Developers should audit their dependencies for malicious packages, and update any packages using npm upgrade/npm override, or yarn up/yarn resolutions
References
Fixes: debug-js/debug#1005 (comment)
See: https://socket.dev/blog/npm-author-qix-compromised-in-major-supply-chain-attack
Checklist