Skip to content

chore: Bump Snaps packages #23976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FrederikBolding merged 2 commits into from
Dec 17, 2025
Merged

chore: Bump Snaps packages #23976

FrederikBolding merged 2 commits into from
Dec 17, 2025
+6 −6

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Dec 12, 2025 •
edited by cursor bot
Loading

Description

Bumps the Snaps packages to the latest version. This release is a hotfix release that mitigates an issue where lack of persistence during initialization would cause Snaps to lose permissions when restarting the app.

Note

Update @metamask/snaps-controllers from ^17.1.1 to ^17.1.2.

Written by Cursor Bugbot for commit fe4f7f1. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-core-platform Core Platform team label Dec 12, 2025
@FrederikBolding FrederikBolding mentioned this pull request Dec 12, 2025
Merged
Gudahtt
Gudahtt approved these changes Dec 12, 2025
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@socket-security
Copy link

socket-security bot commented Dec 12, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​snaps-controllers@​17.1.1 ⏵ 17.1.298 +210076 +19850

View full report

@joaoloureirop joaoloureirop added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Dec 12, 2025
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Dec 12, 2025
@cmd-ob cmd-ob mentioned this pull request Dec 12, 2025
Merged
7 tasks
@Gudahtt
Copy link
Member

Gudahtt commented Dec 12, 2025

The test SmokePredictions: Claim winnings: › claim winnings via market details is consistently failing here, but it's working on main and on other PRs.

I even retried 3 times on this branch, and retried a few main commits, and it's always failing here but passing elsewhere

joaoloureirop pushed a commit that referenced this pull request Dec 12, 2025
@FrederikBolding @sethkfman
fix: Add patch to mitigate persistence issues impacting Snaps (#23973)
23fdbf1 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Patch to bring in the changes from:
#23976 /
MetaMask/snaps#3775 to the RC, which fixes a
production issue preventing Snaps from executing properly due to a
persistence bug. The patch was created by building the main Snaps branch
locally and copying over the SnapController files.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Switches @metamask/snaps-controllers to a Yarn patch and updates
yarn.lock accordingly.
> 
> - **Dependencies**:
> - Switch `@metamask/[email protected]` to a Yarn patch
reference in `package.json`.
> - Update `yarn.lock` to resolve the patched package (new
entries/resolutions and checksums).
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
8a44c10. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: sethkfman <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.91%. Comparing base (4d23ec5) to head (5e53712).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #23976   +/-   ##
=======================================
  Coverage   78.90%   78.91%           
=======================================
  Files        4047     4046    -1     
  Lines      106125   106147   +22     
  Branches    21448    21461   +13     
=======================================
+ Hits        83742    83761   +19     
- Misses      16535    16536    +1     
- Partials     5848     5850    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding force-pushed the fb/snaps-bump-v136 branch 4 times, most recently from 7197c41 to 812565c Compare December 16, 2025 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeCore, SmokeAccounts, SmokeMultiChainAPI, SmokeNetworkExpansion
  • Risk Level: medium
  • AI Confidence: 75%
click to see 🤖 AI reasoning details

This PR updates @metamask/snaps-controllers from version 17.1.1 to 17.1.2 - a minor patch version bump. The snaps-controllers package is a critical dependency used extensively throughout the codebase, particularly in:

  1. Core Engine controllers (app/core/Engine/controllers/snaps/) - SnapController, CronjobController, SnapInterfaceController, etc.
  2. Engine messengers (app/core/Engine/messengers/snaps/) - Various snap-related messengers
  3. SnapKeyring (app/core/SnapKeyring/) - Snap-based keyring functionality
  4. Multichain routing - MultichainRouter uses snaps-controllers

While this is just a patch version update (typically bug fixes only), the package touches critical wallet infrastructure. The selected tags cover:

  • SmokeCore: Core wallet functionality that snaps integrate with
  • SmokeAccounts: Snap keyrings and BIP-44 functionality
  • SmokeMultiChainAPI: Multichain router depends on snaps-controllers
  • SmokeNetworkExpansion: Non-EVM networks (Solana, Bitcoin) use snaps

Note: The dedicated snaps tests use FlaskBuildTests tag which is not in the available smoke test tags, so those specific snap tests won't be triggered by these tags. The selected tags provide coverage for the areas that integrate with snaps functionality.

View GitHub Actions results

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@FrederikBolding FrederikBolding added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main with commit c66b195 Dec 17, 2025
89 checks passed
@FrederikBolding FrederikBolding deleted the fb/snaps-bump-v136 branch December 17, 2025 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2025
@metamaskbot metamaskbot added the release-7.62.0 Issue or pull request that will be included in release 7.62.0 label Dec 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.62.0 Issue or pull request that will be included in release 7.62.0 size-XS team-core-platform Core Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@FrederikBolding @Gudahtt @codecov-commenter @metamaskbot @joaoloureirop