Repository navigation
fix: replace broken Learn more URL in Added Protection row - #42963
Open
tenderdeve wants to merge 2 commits into
Open
tenderdeve wants to merge 2 commits into
tenderdeve wants to merge 2 commits into
Conversation
The enforced-simulations "Learn more" link pointed to a MetaMask support article path that was never published, causing a 404. Move the URL to a named constant in shared/lib/ui-utils.ts (pointing to the existing simulations article) and import it in enforced-simulations-row.tsx, matching the pattern used by shield-footer-agreement.tsx. Fixes MetaMask#42908
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit fc0bdc1. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://support.metamask.io/privacy-and-security/staying-safe-in-web3/what-are-enforced-simulations/— a URL that was never published, resulting in a 404.ENFORCED_SIMULATIONS_LEARN_MORE_LINKinshared/lib/ui-utils.ts, pointing to the existing simulations support article (transactions-and-gas/transactions/simulations/).enforced-simulations-row.tsxand imported the new one — matching the pattern used byshield-footer-agreement.tsx.Fixes #42908
Test plan
yarn test:unitfor the affected component)Note
Low Risk
Single UI href change with no auth, transaction, or data-handling impact.
Overview
Fixes the Added Protection row Learn more link on transaction confirmations, which previously used an unpublished support URL that returned 404.
The row now uses the shared
TRANSACTION_SIMULATIONS_LEARN_MORE_LINKfromshared/lib/ui-utils(the published simulations article) instead of a local constant, aligning with other simulations help links in the extension.Reviewed by Cursor Bugbot for commit f47b565. Bugbot is set up for automated code reviews on this repo. Configure here.