Skip to content

fix: fix fee limit naming #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bfullam merged 3 commits into from
Jan 7, 2026
Merged

fix: fix fee limit naming #7571

bfullam merged 3 commits into from
Jan 7, 2026

Conversation

@bfullam
Copy link
Contributor

@bfullam bfullam commented Jan 7, 2026 •
edited by cursor bot
Loading

Explanation

Rename fee_limit param to feeLimit. Necessary for Tron snap

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Aligns Tron snap fee computation option naming.

  • Update packages/bridge-controller/src/utils/quote-fees.ts to pass feeLimit (camelCase) instead of fee_limit when computing fees for Tron trades
  • Document fix in packages/bridge-controller/CHANGELOG.md under Unreleased → Fixed

Written by Cursor Bugbot for commit 878fe3f. This will update automatically on new commits. Configure here.

@bfullam bfullam requested a review from a team as a code owner January 7, 2026 12:43
@bfullam bfullam requested a review from a team as a code owner January 7, 2026 12:43
GeorgeGkas
GeorgeGkas previously approved these changes Jan 7, 2026
View reviewed changes
@bfullam bfullam enabled auto-merge January 7, 2026 12:45
@GeorgeGkas GeorgeGkas self-requested a review January 7, 2026 15:23
@bfullam bfullam added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit d531786 Jan 7, 2026
286 checks passed
@bfullam bfullam deleted the swaps-fix-feeLimit-naming branch January 7, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeorgeGkas GeorgeGkas GeorgeGkas approved these changes

@ghgoodreau ghgoodreau ghgoodreau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bfullam @GeorgeGkas @ghgoodreau