Skip to content

Conversation

@lwin-kyaw
Copy link
Contributor

@lwin-kyaw lwin-kyaw commented Jan 7, 2026

Explanation

This PR removed usage of global console.error and replaced with module logger.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Shifts ClaimsService error logging to a structured module logger and documents the change.

  • Introduces src/logger.ts with projectLogger and re-exports createModuleLogger
  • Replaces console.error with createModuleLogger(projectLogger, 'ClaimsService') in ClaimsService catch blocks (fetchClaimsConfigurations, getClaims, getClaimById, generateMessageForClaimSignature)
  • Updates CHANGELOG.md under Unreleased to reflect logging change

Written by Cursor Bugbot for commit 67bc4e3. This will update automatically on new commits. Configure here.

@lwin-kyaw lwin-kyaw requested a review from a team as a code owner January 7, 2026 11:49
@lwin-kyaw lwin-kyaw requested a review from a team as a code owner January 7, 2026 11:51
@lwin-kyaw lwin-kyaw added area-shield Transaction Shield team-shield labels Jan 7, 2026
@lwin-kyaw
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "4.0.0-preview-67bc4e39",
  "@metamask-previews/accounts-controller": "35.0.0-preview-67bc4e39",
  "@metamask-previews/address-book-controller": "7.0.1-preview-67bc4e39",
  "@metamask-previews/analytics-controller": "1.0.0-preview-67bc4e39",
  "@metamask-previews/announcement-controller": "8.0.0-preview-67bc4e39",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-67bc4e39",
  "@metamask-previews/approval-controller": "8.0.0-preview-67bc4e39",
  "@metamask-previews/assets-controllers": "94.1.0-preview-67bc4e39",
  "@metamask-previews/base-controller": "9.0.0-preview-67bc4e39",
  "@metamask-previews/bridge-controller": "64.2.0-preview-67bc4e39",
  "@metamask-previews/bridge-status-controller": "64.2.0-preview-67bc4e39",
  "@metamask-previews/build-utils": "3.0.4-preview-67bc4e39",
  "@metamask-previews/chain-agnostic-permission": "1.4.0-preview-67bc4e39",
  "@metamask-previews/claims-controller": "0.4.0-preview-67bc4e39",
  "@metamask-previews/composable-controller": "12.0.0-preview-67bc4e39",
  "@metamask-previews/controller-utils": "11.17.0-preview-67bc4e39",
  "@metamask-previews/core-backend": "5.0.0-preview-67bc4e39",
  "@metamask-previews/delegation-controller": "2.0.0-preview-67bc4e39",
  "@metamask-previews/earn-controller": "11.0.0-preview-67bc4e39",
  "@metamask-previews/eip-5792-middleware": "2.1.0-preview-67bc4e39",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-67bc4e39",
  "@metamask-previews/eip1193-permission-middleware": "1.0.3-preview-67bc4e39",
  "@metamask-previews/ens-controller": "19.0.0-preview-67bc4e39",
  "@metamask-previews/error-reporting-service": "3.0.1-preview-67bc4e39",
  "@metamask-previews/eth-block-tracker": "15.0.0-preview-67bc4e39",
  "@metamask-previews/eth-json-rpc-middleware": "22.0.1-preview-67bc4e39",
  "@metamask-previews/eth-json-rpc-provider": "6.0.0-preview-67bc4e39",
  "@metamask-previews/foundryup": "1.0.1-preview-67bc4e39",
  "@metamask-previews/gas-fee-controller": "26.0.0-preview-67bc4e39",
  "@metamask-previews/gator-permissions-controller": "0.8.0-preview-67bc4e39",
  "@metamask-previews/json-rpc-engine": "10.2.0-preview-67bc4e39",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-67bc4e39",
  "@metamask-previews/keyring-controller": "25.0.0-preview-67bc4e39",
  "@metamask-previews/logging-controller": "7.0.1-preview-67bc4e39",
  "@metamask-previews/message-manager": "14.1.0-preview-67bc4e39",
  "@metamask-previews/messenger": "0.3.0-preview-67bc4e39",
  "@metamask-previews/multichain-account-service": "4.1.0-preview-67bc4e39",
  "@metamask-previews/multichain-api-middleware": "1.2.5-preview-67bc4e39",
  "@metamask-previews/multichain-network-controller": "3.0.0-preview-67bc4e39",
  "@metamask-previews/multichain-transactions-controller": "7.0.0-preview-67bc4e39",
  "@metamask-previews/name-controller": "9.0.0-preview-67bc4e39",
  "@metamask-previews/network-controller": "27.1.0-preview-67bc4e39",
  "@metamask-previews/network-enablement-controller": "4.0.0-preview-67bc4e39",
  "@metamask-previews/notification-services-controller": "21.0.0-preview-67bc4e39",
  "@metamask-previews/permission-controller": "12.2.0-preview-67bc4e39",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-67bc4e39",
  "@metamask-previews/phishing-controller": "16.1.0-preview-67bc4e39",
  "@metamask-previews/polling-controller": "16.0.0-preview-67bc4e39",
  "@metamask-previews/preferences-controller": "22.0.0-preview-67bc4e39",
  "@metamask-previews/profile-metrics-controller": "2.0.0-preview-67bc4e39",
  "@metamask-previews/profile-sync-controller": "27.0.0-preview-67bc4e39",
  "@metamask-previews/ramps-controller": "2.0.0-preview-67bc4e39",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-67bc4e39",
  "@metamask-previews/remote-feature-flag-controller": "4.0.0-preview-67bc4e39",
  "@metamask-previews/sample-controllers": "4.0.0-preview-67bc4e39",
  "@metamask-previews/seedless-onboarding-controller": "7.1.0-preview-67bc4e39",
  "@metamask-previews/selected-network-controller": "26.0.0-preview-67bc4e39",
  "@metamask-previews/shield-controller": "4.1.0-preview-67bc4e39",
  "@metamask-previews/signature-controller": "38.0.0-preview-67bc4e39",
  "@metamask-previews/storage-service": "0.0.1-preview-67bc4e39",
  "@metamask-previews/subscription-controller": "5.4.0-preview-67bc4e39",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-67bc4e39",
  "@metamask-previews/transaction-controller": "62.7.0-preview-67bc4e39",
  "@metamask-previews/transaction-pay-controller": "10.5.0-preview-67bc4e39",
  "@metamask-previews/user-operation-controller": "41.0.0-preview-67bc4e39"
}

@lwin-kyaw lwin-kyaw enabled auto-merge January 7, 2026 12:20
@lwin-kyaw lwin-kyaw added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit e9b2c41 Jan 7, 2026
286 checks passed
@lwin-kyaw lwin-kyaw deleted the feat/claims-logger branch January 7, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-shield Transaction Shield team-shield

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants