Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Jan 5, 2026

Explanation

This PR aims to update error message when transaction failed on-chain to make it explicit on the metrics.

Note: I wanted to put revert reason but receipt doesn't have any info. It will be unnecessary effort to debug receipt logs just for metrics so ended up updating message as described in the task.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Cursor Bugbot is generating a summary for commit ff48ec9. Configure here.

@OGPoyraz OGPoyraz marked this pull request as ready for review January 5, 2026 11:58
@OGPoyraz OGPoyraz requested review from a team as code owners January 5, 2026 11:58
@OGPoyraz OGPoyraz changed the title fix: Change error message when transaction failed on-chain fix: Update error message when transaction failed on-chain Jan 5, 2026
@OGPoyraz OGPoyraz changed the title fix: Update error message when transaction failed on-chain fix: Update error message for failed on-chain transactions Jan 5, 2026
@OGPoyraz OGPoyraz added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit b61595c Jan 5, 2026
286 checks passed
@OGPoyraz OGPoyraz deleted the ogp/5265 branch January 5, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants