chore: bump snaps dependencies #7550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ccharly
commented
Jan 5, 2026
...es/assets-controllers/src/MultichainAssetsRatesController/MultichainAssetsRatesController.ts
Outdated
Show resolved
Hide resolved
ccharly
commented
Jan 5, 2026
Comment on lines
+488
to
+495
| const assetMarketData = response.marketData?.[asset]?.[currency]; | ||
|
|
||
| // We do not consider NFTs here, so `fungible` must be `true`. | ||
| if (assetMarketData?.fungible) { | ||
| assetToMarketData[asset] = assetMarketData; | ||
| } else { | ||
| assetToMarketData[asset] = undefined; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
OnAssetsMarketData now also include NFTs asset type. So we have to filter them out. Using if (assetMarketData?.fungible) is enough, since we use this boolean as a tag to disambiguate both data structures (NFT vs fungible tokens).
cc @MetaMask/metamask-assets
sahar-fehri
approved these changes
Jan 5, 2026
FrederikBolding
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Bumping all
@metamask/snaps-*packages to match the latest versions (that are already in-use on both clients)References
N/A
Checklist
Note
Updates dependency stack to align with latest Snaps ecosystem.
@metamask/snaps-controllersto^17.2.0,@metamask/snaps-sdkto^10.3.0, and@metamask/snaps-utilsto^11.7.0across packages (accounts, account-tree, assets, bridge, bridge-status, gator-permissions, multichain-account-service, multichain-transactions, profile-sync)@metamask/providers@^22.1.1,@metamask/rpc-errors@^7.0.3,@metamask/phishing-controller@^15.0.1,@metamask/snaps-registry@^4.0.0,@metamask/snaps-rpc-methods@^14.1.1, andses@^1.14.0MultichainAssetsRatesController.ts: map market data only whenfungibleis true, excluding NFTsWritten by Cursor Bugbot for commit 55e4128. This will update automatically on new commits. Configure here.