make new variables optional #7521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalsys
deleted the
fix/make-new-remote-feature-flag-controller-variables-optional
branch
asalsys
added a commit
that referenced
this pull request
Dec 16, 2025
## Explanation The `localOverrides` and `rawRemoteFeatureFlags` properties were recently added to `RemoteFeatureFlagControllerState` in PR #7271 as required properties. However, consumers with existing persisted state from before these properties were added will experience TypeScript errors when their state is loaded, since these properties won't exist in the persisted data but are marked as required. This PR marks `localOverrides` and `rawRemoteFeatureFlags` as optional in the `RemoteFeatureFlagControllerState` type to ensure backwards compatibility with existing persisted state. The `getDefaultRemoteFeatureFlagControllerState()` function continues to initialize these properties with empty objects, so newly created state will still have them populated. ## References - Related to #7271 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
localOverridesandrawRemoteFeatureFlagsproperties were recently added toRemoteFeatureFlagControllerStatein PR #7271 as required properties. However, consumers with existing persisted state from before these properties were added will experience TypeScript errors when their state is loaded, since these properties won't exist in the persisted data but are marked as required.This PR marks
localOverridesandrawRemoteFeatureFlagsas optional in theRemoteFeatureFlagControllerStatetype to ensure backwards compatibility with existing persisted state. ThegetDefaultRemoteFeatureFlagControllerState()function continues to initialize these properties with empty objects, so newly created state will still have them populated.References
Checklist