Skip to content

Conversation

@bergarces
Copy link
Contributor

@bergarces bergarces commented Dec 15, 2025

Explanation

Export selector so it can be used to get assets from account groups other than the currently selected one.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Expose selectAllAssets by exporting it from selectors/token-selectors and re-exporting via package src/index.ts, with changelog updated.

  • Assets Controllers
    • Exports:
      • Make selectAllAssets export in packages/assets-controllers/src/selectors/token-selectors.ts.
      • Re-export selectAllAssets from packages/assets-controllers/src/index.ts alongside selectAssetsBySelectedAccountGroup.
    • Docs:
      • Update packages/assets-controllers/CHANGELOG.md under Unreleased to note export of selectAllAssets.

Written by Cursor Bugbot for commit eb60826. This will update automatically on new commits. Configure here.

@bergarces bergarces requested a review from a team as a code owner December 15, 2025 12:20
@bergarces bergarces requested a review from a team as a code owner December 15, 2025 12:29
@bergarces
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-tree-controller": "4.0.0-preview-eb60826c",
  "@metamask-previews/accounts-controller": "35.0.0-preview-eb60826c",
  "@metamask-previews/address-book-controller": "7.0.1-preview-eb60826c",
  "@metamask-previews/analytics-controller": "0.0.0-preview-eb60826c",
  "@metamask-previews/announcement-controller": "8.0.0-preview-eb60826c",
  "@metamask-previews/app-metadata-controller": "2.0.0-preview-eb60826c",
  "@metamask-previews/approval-controller": "8.0.0-preview-eb60826c",
  "@metamask-previews/assets-controllers": "94.1.0-preview-eb60826c",
  "@metamask-previews/base-controller": "9.0.0-preview-eb60826c",
  "@metamask-previews/bridge-controller": "64.1.0-preview-eb60826c",
  "@metamask-previews/bridge-status-controller": "64.1.0-preview-eb60826c",
  "@metamask-previews/build-utils": "3.0.4-preview-eb60826c",
  "@metamask-previews/chain-agnostic-permission": "1.3.0-preview-eb60826c",
  "@metamask-previews/claims-controller": "0.2.0-preview-eb60826c",
  "@metamask-previews/composable-controller": "12.0.0-preview-eb60826c",
  "@metamask-previews/controller-utils": "11.16.0-preview-eb60826c",
  "@metamask-previews/core-backend": "5.0.0-preview-eb60826c",
  "@metamask-previews/delegation-controller": "2.0.0-preview-eb60826c",
  "@metamask-previews/earn-controller": "11.0.0-preview-eb60826c",
  "@metamask-previews/eip-5792-middleware": "2.0.0-preview-eb60826c",
  "@metamask-previews/eip-7702-internal-rpc-middleware": "0.1.0-preview-eb60826c",
  "@metamask-previews/eip1193-permission-middleware": "1.0.3-preview-eb60826c",
  "@metamask-previews/ens-controller": "19.0.0-preview-eb60826c",
  "@metamask-previews/error-reporting-service": "3.0.0-preview-eb60826c",
  "@metamask-previews/eth-block-tracker": "15.0.0-preview-eb60826c",
  "@metamask-previews/eth-json-rpc-middleware": "22.0.1-preview-eb60826c",
  "@metamask-previews/eth-json-rpc-provider": "6.0.0-preview-eb60826c",
  "@metamask-previews/foundryup": "1.0.1-preview-eb60826c",
  "@metamask-previews/gas-fee-controller": "26.0.0-preview-eb60826c",
  "@metamask-previews/gator-permissions-controller": "0.8.0-preview-eb60826c",
  "@metamask-previews/json-rpc-engine": "10.2.0-preview-eb60826c",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.8-preview-eb60826c",
  "@metamask-previews/keyring-controller": "25.0.0-preview-eb60826c",
  "@metamask-previews/logging-controller": "7.0.1-preview-eb60826c",
  "@metamask-previews/message-manager": "14.1.0-preview-eb60826c",
  "@metamask-previews/messenger": "0.3.0-preview-eb60826c",
  "@metamask-previews/multichain-account-service": "4.0.1-preview-eb60826c",
  "@metamask-previews/multichain-api-middleware": "1.2.5-preview-eb60826c",
  "@metamask-previews/multichain-network-controller": "3.0.0-preview-eb60826c",
  "@metamask-previews/multichain-transactions-controller": "7.0.0-preview-eb60826c",
  "@metamask-previews/name-controller": "9.0.0-preview-eb60826c",
  "@metamask-previews/network-controller": "27.0.0-preview-eb60826c",
  "@metamask-previews/network-enablement-controller": "4.0.0-preview-eb60826c",
  "@metamask-previews/notification-services-controller": "21.0.0-preview-eb60826c",
  "@metamask-previews/permission-controller": "12.1.1-preview-eb60826c",
  "@metamask-previews/permission-log-controller": "5.0.0-preview-eb60826c",
  "@metamask-previews/phishing-controller": "16.1.0-preview-eb60826c",
  "@metamask-previews/polling-controller": "16.0.0-preview-eb60826c",
  "@metamask-previews/preferences-controller": "22.0.0-preview-eb60826c",
  "@metamask-previews/profile-metrics-controller": "2.0.0-preview-eb60826c",
  "@metamask-previews/profile-sync-controller": "27.0.0-preview-eb60826c",
  "@metamask-previews/ramps-controller": "1.0.0-preview-eb60826c",
  "@metamask-previews/rate-limit-controller": "7.0.0-preview-eb60826c",
  "@metamask-previews/remote-feature-flag-controller": "3.0.0-preview-eb60826c",
  "@metamask-previews/sample-controllers": "4.0.0-preview-eb60826c",
  "@metamask-previews/seedless-onboarding-controller": "7.1.0-preview-eb60826c",
  "@metamask-previews/selected-network-controller": "26.0.0-preview-eb60826c",
  "@metamask-previews/shield-controller": "4.0.0-preview-eb60826c",
  "@metamask-previews/signature-controller": "38.0.0-preview-eb60826c",
  "@metamask-previews/storage-service": "0.0.1-preview-eb60826c",
  "@metamask-previews/subscription-controller": "5.4.0-preview-eb60826c",
  "@metamask-previews/token-search-discovery-controller": "4.0.0-preview-eb60826c",
  "@metamask-previews/transaction-controller": "62.6.0-preview-eb60826c",
  "@metamask-previews/transaction-pay-controller": "10.5.0-preview-eb60826c",
  "@metamask-previews/user-operation-controller": "41.0.0-preview-eb60826c"
}

@bergarces bergarces added this pull request to the merge queue Dec 15, 2025
Merged via the queue into main with commit 1bd1048 Dec 15, 2025
285 checks passed
@bergarces bergarces deleted the export-new-selector branch December 15, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants