Explanation

Current state and why it needs to change

The AccountTrackerController previously had inconsistent lock/unlock handling compared to TokenBalancesController:

1. No lock state tracking: The controller had no way to track whether the keyring was locked, meaning it could attempt balance fetches even when the wallet was locked.

2. Refresh on unlock: When KeyringController:unlock was fired, it would immediately trigger a full balance refresh for all networks. This behavior was unnecessary since polling continues regardless of lock state.

3. Refresh all networks on network add: When a new network was added via NetworkController:networkAdded, the controller would refresh balances for all networks instead of just the newly added one.

Solution

This PR aligns AccountTrackerController with the pattern already established in TokenBalancesController:

1. Added #isLocked property: Tracks whether the keyring is locked, initialized from KeyringController:getState in the constructor.

2. Added isActive getter: Returns true when the keyring is unlocked AND the user is onboarded. Balance fetching is skipped when isActive is false.

3. Subscribe to KeyringController:lock: Sets #isLocked = true when the keyring is locked.

4. Updated KeyringController:unlock subscription: Now only sets #isLocked = false without triggering an immediate refresh. Polling continues as normal and will fetch balances on the next interval.

5. Optimized NetworkController:networkAdded handler: Now extracts the networkClientId from the added network configuration and only refreshes balances for that specific network.

Breaking changes

• AccountTrackerController messenger must now allow KeyringController:getState action
• AccountTrackerController messenger must now allow KeyringController:lock event

References

• Similar pattern exists in TokenBalancesController (#isUnlocked property and isActive getter)

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've communicated my changes to consumers by updating changelogs for packages I've changed
• I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them