refactor: deprecate transaction history and sendFlowHistory properties
#7326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
vinistevam
changed the title
history and sendFlowHistory properties
Contributor
Author
|
Extension draft PR: MetaMask/metamask-extension#38665 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
matthewwalsh0
requested changes
Dec 11, 2025
packages/transaction-controller/src/helpers/IncomingTransactionHelper.test.ts
Show resolved
Hide resolved
Co-authored-by: Matthew Walsh <[email protected]>
…e into fix/remove-history-property
matthewwalsh0
previously approved these changes
Dec 18, 2025
| _sendFlowHistoryToAdd: SendFlowHistoryEntry[], | ||
| ): TransactionMeta { | ||
| // Return the transaction unchanged | ||
| return this.#getTransaction(transactionID) as TransactionMeta; |
Member
There was a problem hiding this comment.
Very minor, could use getTransactionOrThrow to avoid the need to cast.
…e into fix/remove-history-property
matthewwalsh0
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR deprecates the
historyandsendFlowHistoryproperties and all the code related.Problem
Extension state size has been identified as a major root cause for the app becoming bricked, particularly for power users. Analysis by the platform team revealed that
historyandsendFlowHistoryare among the biggest contributors to excessive state size, leading to frequent disk writes and the infinite spinner issue.References
fixes https://github.com/MetaMask/MetaMask-planning/issues/2465
Checklist
Note
Deprecates
history/sendFlowHistory, removes history utilities/exports, makes history updates no-ops, and updates controller, types, and tests accordingly.utils/history(addInitialHistorySnapshot,updateTransactionHistory); stop recording mutation history.disableHistoryanddisableSendFlowHistory(kept for backward compatibility; no longer used).updateTransactionSendFlowHistorya no-op returning the transaction unchanged.skipHistory, history notes now just logged).TransactionMeta.history,sendFlowHistory,TransactionHistory, andTransactionHistoryEntryas deprecated.DISPLAYED_TRANSACTION_HISTORY_PATHSandMAX_TRANSACTION_HISTORY_LENGTHfrom package index.historyandsendFlowHistory.Written by Cursor Bugbot for commit 9d2d2b1. This will update automatically on new commits. Configure here.