fix: Tx state listener and signature coverage #6906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
@metamaskbot publish-preview |
lwin-kyaw
commented
Oct 21, 2025
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lwin-kyaw
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
@metamaskbot publish-preview |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
tuna1207
approved these changes
Oct 22, 2025
chaitanyapotti
approved these changes
Oct 22, 2025
Gudahtt
added a commit
that referenced
this pull request
Oct 24, 2025
…r/multichain-transactions-controller * origin/main: (35 commits) feat: `JsonRpcEngineV2` (#6176) Release 641.0.0 (#6940) feat: Add transaction emulation actions (#6935) Release/640.0.0 (#6934) fix(core-backend): control randomness to fix flaky test (#6936) chore: Add `@metamask-previews/*` to NPM age gate exceptions (#6937) Release/639.0.0 (#6931) feat: make getCryptoApproveTransactionParams synchronous (#6930) feat: add new actions to `KeyringController` (#6928) feat: add `getAccounts` to `AccountsController` (#6927) chore: remove `Monad Mainnet` single call balance contract and add into account v4 (#6929) Release/638.0.0 (#6923) fix: Downgrade `multiformats` to `^9.9.0` to avoid ESM-only dependency (#6920) Release/637.0.0 (#6919) feat(account-tree-controller): add callbacks for hidden and pinned data (#6910) Release 636.0.0 (#6918) fix(core-backend): reconnection logic (#6861) fix: Tx state listener and signature coverage (#6906) Release/635.0.0 (#6917) fix(base-controller): add TypeScript declaration file for legacy module resolution (#6915) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR includes ~
personal_coveragecheck in the signature-coverage resultTransactionMeta.SimulationDatainstead of referential equality in tx-coverage check, to avoid triggering multiple coverage check requests.normalizeSignatureRequestfunction which normalize the requests for TypedSignature similar to the security-alerts API.makeInitSignatureCoverageCheckBodyfunction as signature data is not alwaysstring(e.g.eth_signTypedDatauses Array of Object) and the data is already validated in the SignatureController before adding to the state.References
Checklist
Note
Adds request normalization and method parsing for signatures, triggers signature coverage for all new requests, and uses deep equality for transaction simulationData to reduce redundant checks.
signatureRequests(removespersonal_sign-only gate).txMeta.simulationDatato re-check coverage only on meaningful changes.normalizeSignatureRequestoption; clones and normalizes before backend call.InitSignatureCoverageCheckRequest.datanow acceptsJson; removed string-only validation.parseSignatureRequestMethodto derive correct JSON-RPC method (handles typed sign V1/V3/V4) and uses it in init body.parseSignatureRequestMethodandNormalizeSignatureRequestFn.SignTypedDataVersionenum.lodash(forcloneDeep/isEqual).Written by Cursor Bugbot for commit 7adaa54. This will update automatically on new commits. Configure here.