feat(json-rpc-engine): Type-safe context inference #6902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
changed the base branch from
main
to
rekm/json-rpc-engine-rewrite-next
rekmarks
force-pushed
the
rekm/temp-context-generic-factory
branch
from
83ab221 to
a45a3c5
Compare
rekmarks
changed the title
mcmire
approved these changes
Oct 23, 2025
Contributor
mcmire
left a comment
mcmire
left a comment
There was a problem hiding this comment.
Had one question about representing an invalid engine better, as well as some other comments. None of this is blocking though. I think this works really well.
|
|
||
| it('type errors and returns undefined when getting unknown keys', () => { | ||
| const context = new MiddlewareContext<{ test: string }>(); | ||
| // @ts-expect-error - foo is not a valid key |
Contributor
There was a problem hiding this comment.
Nit: Would it be worth adding tsd or tstyche tests at some point for some of these classes? This would allow us to write assertions at the type level.
Member
Author
There was a problem hiding this comment.
I think we're squeaking by with @ts-expect-error for now, although I'm not opposed to the idea if we think it becomes warranted.
rekmarks
merged commit 471ff5e
into
rekm/json-rpc-engine-rewrite-next
11 of 12 checks passed
rekmarks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Introduce generic, type-safe MiddlewareContext and JsonRpcEngineV2.create() factory with improved type inference; update server, utils/exports, tests, and docs accordingly.
JsonRpcEngineV2.create()static factory; make constructor private and enforce non-empty middleware.Context,ResultConstraint; improved request/notification typing and composition.handle()/asMiddleware(); validate incompatible contexts at type level; new internal invalid-engine typing.MiddlewareContextgeneric with strict key/value typing; addassertGet/settypings,EmptyContext, andMergeContextsutil.Json,JsonRpcParams; addUnionToIntersectiontype.JsonRpcEngineErrorwith cross-versionisInstance().create()when passed middleware; clarify/adjust param validation and id handling.propagateToContextto accept typed context; minor param-handling tweaks.create()and new helper middlewares; add coverage for context typing, invalid compositions, and new behaviors.create(), typed middleware/context, composition patterns, and error semantics.Written by Cursor Bugbot for commit 75f61e7. This will update automatically on new commits. Configure here.