-
-
Notifications
You must be signed in to change notification settings - Fork 266
refactor: migrate TokenSearchDiscoveryController to @metamask/messenger
#6495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FrederikBolding
merged 5 commits into
main
from
cryptodev-2s/messenger/token-search-discovery-controller
Oct 27, 2025
Merged
refactor: migrate TokenSearchDiscoveryController to @metamask/messenger
#6495
FrederikBolding
merged 5 commits into
main
from
cryptodev-2s/messenger/token-search-discovery-controller
Oct 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5c6e50 to
1d9486b
Compare
43 tasks
1d9486b to
52b655c
Compare
mcmire
previously approved these changes
Sep 10, 2025
52b655c to
e3a3622
Compare
e3a3622 to
fa22b4a
Compare
mcmire
previously approved these changes
Oct 7, 2025
Contributor
mcmire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…r/token-search-discovery-controller
Mrtenz
approved these changes
Oct 27, 2025
auto-merge was automatically disabled
October 27, 2025 11:43
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
TokenSearchDiscoveryControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Migrates
TokenSearchDiscoveryControllerto@metamask/messengerand renames metadataanonymoustoincludeInDebugSnapshot, with corresponding test, config, and docs updates.Messengerfrom@metamask/messenger; update controller messenger types and constructor wiring.@metamask/base-controller/next.anonymous→includeInDebugSnapshot.@metamask/messengerand updatetsconfigproject references.Messengerhierarchy; update metadata key usage.token_search_discovery_controller --> messenger,eip_7702_internal_rpc_middleware --> controller_utils).Written by Cursor Bugbot for commit f545217. This will update automatically on new commits. Configure here.