fix: integer overflow in ports iteration

wwqgtxx · wwqgtxx · commit 05e8f13a8d65 · 2025-02-28T15:48:25.000+08:00
diff --git a/common/utils/ranges.go b/common/utils/ranges.go
@@ -139,10 +139,13 @@ func (ranges IntRanges[T]) Range(f func(t T) bool) {
 	}
 
 	for _, r := range ranges {
-		for i := r.Start(); i <= r.End(); i++ {
+		for i := r.Start(); i <= r.End() && i >= r.Start(); i++ {
 			if !f(i) {
 				return
 			}
+			if i+1 < i { // integer overflow
+				break
+			}
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -139,10 +139,13 @@ func (ranges IntRanges[T]) Range(f func(t T) bool) {`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`for _, r := range ranges {`
`142`		`- for i := r.Start(); i <= r.End(); i++ {`
	`142`	`+ for i := r.Start(); i <= r.End() && i >= r.Start(); i++ {`
`143`	`143`	`if !f(i) {`
`144`	`144`	`return`
`145`	`145`	`}`
	`146`	`+ if i+1 < i { // integer overflow`
	`147`	`+ break`
	`148`	`+ }`
`146`	`149`	`}`
`147`	`150`	`}`
`148`	`151`	`}`