Add memory size check to GetMemoryCheckResult
#2172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuecc
approved these changes
Mar 4, 2025
Member
neuecc
left a comment
neuecc
left a comment
There was a problem hiding this comment.
Thank you, I have no objection to including the check.
By the way, I think this is a bug in the implementation of bufferwriter, but are there any standards or equivalent that behave in this way?
Collaborator
Author
|
This does just catch a bug in the buffer writer. You are correct. I've seen a couple buggy implementations before. |
1 task
This was referenced Jul 21, 2025
This was referenced Aug 4, 2025
This was referenced Aug 18, 2025
This was referenced Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add memory size check to
GetMemoryCheckResultFixes #2171