-
-
Notifications
You must be signed in to change notification settings - Fork 754
Add missing recursion guard to CodeAnalysisUtilities.GetTypeParameters
#2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@neuecc With the removal of NB.GV, it's no longer clear to me which version |
neuecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no feeds being distributed, I don't think it's particularly problematic that the version is fixed.
What issues are you concerned about?
|
I like to know whether a branch will target 3.0, 3.1, or something else. Sometimes folks want to know what version (or at least what version band) will include the fix. And I find it useful sometimes when deciding whether a PR should target master or develop. |
|
Oh, it seems the branch management has been operating based on intuition/feeling, and nobody except you seems to understand those rules. |
|
@neuecc So is the idea at present the same as it was before, where |
|
For large-scale updates/refactoring, we might use the develop branch, but since we'll probably just have small fixes for a while, I think working with master branch only should be fine. |
|
Oh, another reason to know the version for a given branch is so I can pick the right milestone on the PR to record the version that will include it. At the moment, the milestones available are 3.0 and 3.1. |
Fixes #2121 (hopefully).