Skip to content

Conversation

@AArnott
Copy link
Collaborator

@AArnott AArnott commented Jan 8, 2025

Fixes #2121 (hopefully).

@AArnott
Copy link
Collaborator Author

AArnott commented Jan 8, 2025

@neuecc With the removal of NB.GV, it's no longer clear to me which version master builds vs. develop. Can you teach me where I can refer in a branch to see what version would be built?
The PR checks build 1.0.0 versions, it seems.

@AArnott AArnott requested a review from neuecc January 8, 2025 13:13
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no feeds being distributed, I don't think it's particularly problematic that the version is fixed.
What issues are you concerned about?

@AArnott
Copy link
Collaborator Author

AArnott commented Jan 9, 2025

I like to know whether a branch will target 3.0, 3.1, or something else. Sometimes folks want to know what version (or at least what version band) will include the fix. And I find it useful sometimes when deciding whether a PR should target master or develop.

@neuecc
Copy link
Member

neuecc commented Jan 9, 2025

Oh, it seems the branch management has been operating based on intuition/feeling, and nobody except you seems to understand those rules.
And currently, there are no rules in place at all.

@AArnott
Copy link
Collaborator Author

AArnott commented Jan 9, 2025

@neuecc So is the idea at present the same as it was before, where master is where to make fixes that should release soon, and develop is where to work on features?

@neuecc
Copy link
Member

neuecc commented Jan 9, 2025

For large-scale updates/refactoring, we might use the develop branch, but since we'll probably just have small fixes for a while, I think working with master branch only should be fine.

@AArnott AArnott merged commit eec61d6 into master Jan 9, 2025
3 checks passed
@AArnott AArnott deleted the fix2121 branch January 9, 2025 15:57
@AArnott
Copy link
Collaborator Author

AArnott commented Jan 9, 2025

Oh, another reason to know the version for a given branch is so I can pick the right milestone on the PR to record the version that will include it. At the moment, the milestones available are 3.0 and 3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stack overflow. (Unity 2022.3.55f1 - 3.0.308 and above)

2 participants