enable analyze union / stop collect field when object marked SuppressSourceGeneration #2106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the code so that Union-related Analyzers, which had been terminated, would now perform analysis.
As for the bug, red underlines don't appear in the source code (I wonder what caused this - I feel like I've encountered this before but can't remember at all).
However, since errors are still displayed in the error list when building, I suppose this is within acceptable limits.
Additionally, when SuppressSourceGeneration=true, I made it not parse the fields.
While there is a side effect that the Analyzer doesn't check all fields, I think it's fine to consider execution permission as almost equivalent.
Whether it's Visual Studio that's the problem, or if it's the v3 architecture that combines Source Generator and Analyzer - there are quite puzzling behaviors when it comes to error reporting.