Skip to content

Conversation

@neuecc
Copy link
Member

@neuecc neuecc commented Dec 25, 2024

I modified the code so that Union-related Analyzers, which had been terminated, would now perform analysis.
As for the bug, red underlines don't appear in the source code (I wonder what caused this - I feel like I've encountered this before but can't remember at all).
However, since errors are still displayed in the error list when building, I suppose this is within acceptable limits.

Additionally, when SuppressSourceGeneration=true, I made it not parse the fields.
While there is a side effect that the Analyzer doesn't check all fields, I think it's fine to consider execution permission as almost equivalent.
Whether it's Visual Studio that's the problem, or if it's the v3 architecture that combines Source Generator and Analyzer - there are quite puzzling behaviors when it comes to error reporting.

@neuecc neuecc changed the title enable analyze union enable analyze union / stop collect field when object marked SuppressSourceGeneration Dec 25, 2024
@neuecc
Copy link
Member Author

neuecc commented Dec 25, 2024

By the way, the current unit testing system for the Source Generator is terrible.
Its resistance to change is too low, which will become a major technical debt for future modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant