Skip to content

Conversation

@neuecc
Copy link
Member

@neuecc neuecc commented Dec 9, 2024

During development, these conditions were easy to get caught on and were uncomfortable.
I want to delete them since they reduce my productivity.

@neuecc neuecc force-pushed the change-editorconfig branch 2 times, most recently from 8d149eb to ec0d736 Compare December 9, 2024 11:10
@AArnott
Copy link
Collaborator

AArnott commented Dec 9, 2024

SA1512 is the only one that has annoyed me, personally. The others feel like good whitespace management IMO.

That said, it's your call.

@neuecc
Copy link
Member Author

neuecc commented Dec 10, 2024

While whitespace looks good in the finished product, it was frustrating that ambiguous states weren't allowed during development.
Turning it off might lead to things being published without being thoroughly enforced, but well, that's that.
SA1512 giving a warning just for Ctrl+K->C is completely unacceptable - this is an extremely terrible rule.

@neuecc neuecc merged commit 3049dea into master Dec 10, 2024
5 checks passed
@neuecc neuecc deleted the change-editorconfig branch December 10, 2024 01:54
@AArnott
Copy link
Collaborator

AArnott commented Dec 10, 2024

SA1512 giving a warning just for Ctrl+K->C is completely unacceptable - this is an extremely terrible rule.

FWIW the policy allows for Ctrl+K, Ctrl+C, executed twice. It creates this policy:

// code comments
////commentedCode();

I personally like that distinction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants