Skip to content

Conversation

@pCYSl5EDgo
Copy link
Contributor

@pCYSl5EDgo pCYSl5EDgo commented Jan 25, 2024

.NET 8 enabled Dynamic PGO by default. Dynamic PGO tends to hide actual performance characteristics. Dynamic PGO should be disabled in benchmarks.

.NET 8 disabled BinaryFormatter.

This PR was originally one segment of #1744 but later I found SerializerBenchmark project was actually not run in .NET 8.
It was run in .NET Core 3.1.
So this PR was made in order to update all Benchmark projects to .NET 8.

@pCYSl5EDgo pCYSl5EDgo mentioned this pull request Jan 25, 2024
14 tasks
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/azp run

@AArnott AArnott added this to the v3.0 milestone Mar 14, 2024
@AArnott AArnott enabled auto-merge March 14, 2024 12:49
@AArnott AArnott disabled auto-merge March 31, 2024 22:21
@AArnott AArnott merged commit 2ba3acb into MessagePack-CSharp:develop Mar 31, 2024
@pCYSl5EDgo pCYSl5EDgo deleted the net8-small-step branch April 1, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants