-
-
Notifications
You must be signed in to change notification settings - Fork 754
Switch from MSBuild properties to an AdditionalFiles json file #1667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
neuecc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's wonderful!
Would the URL for the example schema in the ReadMe be
https://raw.githubusercontent.com/MessagePack-CSharp/MessagePack-CSharp/master/MessagePackAnalyzer.schema.json ?
Also, I think it's fine that the schema.json serves as the document, but it might be nice to have a link to it.
Yes, I should have used
I don't understand. Can you explain more about what you mean? |
OK!
For example
|
This allows unity (which has no msbuild properties) to configure the source generator. Closes #1650
This allows unity (which has no msbuild properties) to configure the source generator via a JSON file passed to the compiler via AdditionalFiles.
Closes #1650