Skip to content

Conversation

@gsino
Copy link

@gsino gsino commented Feb 24, 2021

fix MessagePackGenerator(mpc) and Test for #1111

Add generic type definition to TypeCollector Collect target.

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't deeply understand mpc, but this looks reasonable to me, and includes tests. Thank you, @gsino.
@neuecc can you take a look?

@AArnott AArnott requested a review from neuecc March 18, 2021 23:31
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope of change is small, so I think it will be fine. Thanks.

@AArnott AArnott merged commit ffc1831 into MessagePack-CSharp:master Mar 21, 2021
@gsino
Copy link
Author

gsino commented Mar 22, 2021

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants