Fix deserialize typeless extension without typeless formatter specified #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
approved these changes
Aug 19, 2020
Collaborator
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
Looks good. Nice catch on the bug and fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deserializing extension field via
TypelessFormatter::Deserializebut withoutThisLibraryExtensionTypeCodes.TypelessFormattershown up in the field extension header, the current deserialize code reads the extension header but doesn't restore it for the following fallback code. This causes fallback deserialize code parsing remaining message payload as header and corrupt the parsing process.This PR fixes it by creating a peek reader for
ExtensionHeadercheck, and only consumes the header when necessary.