Change render format #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Jul 11, 2025
| -- It is not possible to round trip all intervals through PostgreSQL on those | ||
| -- versions. You should upgrade to at least PostgreSQL version 15. For more | ||
| -- information, see this patch: | ||
| -- <https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=e39f99046> |
Collaborator
Author
There was a problem hiding this comment.
As discovered here: yesodweb/persistent#1604 (comment)
Also fix artifact names.
tfausak
commented
Jul 11, 2025
| -- | ||
| -- >>> render MkInterval { months = 0, days = -1, microseconds = 2 } | ||
| -- "@ 0 mon -1 day +2 us" | ||
| -- "@ 0 mon -1 day 0 hour 0 min 0 sec +2 us" |
Collaborator
Author
There was a problem hiding this comment.
This is the main change. This new format supports a wider range of intervals before overflowing older versions of Postgres.
tfausak
commented
Jul 12, 2025
| case result of | ||
| Right actual -> actual `H.shouldBe` [Postgres.Only interval] | ||
| Left somePostgresqlException -> do | ||
| rows <- Postgres.query_ connection "select version()" |
Collaborator
Author
There was a problem hiding this comment.
This should probably use serverVersion instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.