Respect nested .gitignore rules when mining project files#78
Merged
bensig merged 2 commits intoMemPalace:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
|
Beat me by 5min lol. I submitted #80 for the same issue. Quick comparison: this PR reads the root |
Contributor
Author
|
@sha2fiddy yeah, I just kept it simple, I also didn't want to introduce additional dependencies |
ac-opensource
changed the title
Collaborator
|
Looks solid — clean implementation, good test coverage, and no new dependencies. Will merge once CI goes green. |
This was referenced Apr 7, 2026
6 tasks
|
When will we get a release that includes this change @bensig? |
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Project mining now respects
.gitignorefiles as the directory walk descends, so nested repos and subdirectories can apply their own ignore rules instead of only reading the top-level file.It keeps the implementation dependency-free, preserves Git-style precedence for stacked rules, adds
--no-gitignorefor full scans, and adds--include-ignoredfor project-relative escape hatches such asdocs,libsorgenerated/keep.py.It also expands the built-in skip list for common cache and IDE directories.
How to test
python -m pytest tests/ -vruff check ..gitignorefiles, then runmempalace mine <dir> --dry-run--no-gitignoreindexes them again, and--include-ignored docs,libsbrings back only the requested pathsChecklist
python -m pytest tests/ -v)ruff check .)