fix: correct typo in entity_detector interactive classification prompt#728
Closed
arnoldwender wants to merge 7 commits intoMemPalace:developfrom
Closed
fix: correct typo in entity_detector interactive classification prompt#728arnoldwender wants to merge 7 commits intoMemPalace:developfrom
arnoldwender wants to merge 7 commits intoMemPalace:developfrom
Conversation
…mPalace#666) Replace "your memory system" with explicit MemPalace references and tool names (mempalace_diary_write, mempalace_add_drawer, mempalace_kg_add) in stop and precompact hook block reasons. This prevents Claude Code from misinterpreting the hook as a native auto-memory save instruction. Updated in both Python (hooks_cli.py) and standalone shell scripts. Also fix CONTRIBUTING.md Getting Started to show the fork-first workflow, matching the PR Guidelines section.
The current constraint `chromadb>=0.5.0,<0.7` forces pip to install chromadb 0.6.x, but palaces created with chromadb 1.x (which is what the mempalace dev environment actually uses — 1.5.7 per uv.lock) have an incompatible SQLite schema. Specifically, chromadb 0.6.x fails with `KeyError: '_type'` when opening a collection written by 1.x. This means a fresh `pip install mempalace` gives users a chromadb version that cannot read palaces created in the maintainer's own environment. The fix removes the upper bound so pip can resolve to the current stable chromadb release. Reproduction: python3 -m venv .venv && source .venv/bin/activate pip install mempalace # installs chromadb 0.6.3 # Try opening a palace created with chromadb 1.x: # -> _get_collection() returns None, tool_status() returns "No palace found" pip install chromadb==1.5.7 # force upgrade # -> tool_status() returns real data (26k drawers in our case)
'(r)roject' had a duplicate 'r', making it read as '(r)roject' instead of the intended '(r)project'. Small UX fix — no behavior change.
bensig
approved these changes
Apr 12, 2026
Collaborator
bensig
left a comment
bensig
left a comment
There was a problem hiding this comment.
Code review + security audit clean.
bensig
approved these changes
Apr 12, 2026
Collaborator
bensig
left a comment
bensig
left a comment
There was a problem hiding this comment.
Code review + security audit clean.
…constraint fix: remove chromadb <0.7 upper bound — blocks 1.x installs
2 tasks
Member
|
Landed on Thanks for the catch, @arnoldwender! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a one-character typo in the interactive entity classification prompt in
entity_detector.py.Before:
After:
The extra
rmade the option label read as(r)rojectinstead of(r)project. No behavior change — the key bindingrfor project is unaffected.How to test
mempalace detect-entities /path/to/project # Select "edit" mode and verify the prompt reads "(r)project"Checklist
python -m pytest tests/ -v)ruff check .)