fix: add --yes flag to init instructions for non-interactive use (#534)#682
fix: add --yes flag to init instructions for non-interactive use (#534)#682bensig merged 1 commit intoMemPalace:developfrom
Conversation
…Palace#534) AI agents calling `mempalace init` hang on the interactive confirmation prompt. The --yes flag skips it, enabling automated setup. Co-Authored-By: Claude Opus 4.6 <[email protected]>
There was a problem hiding this comment.
Pull request overview
Updates the MemPalace setup instructions to avoid mempalace init hanging in non-interactive automation by using a flag that skips the confirmation prompt.
Changes:
- Update Step 5 command in
init.mdto usemempalace init --yes <dir>.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Run `mempalace init --yes <dir>` where `<dir>` is the directory from Step 4. | ||
|
|
There was a problem hiding this comment.
Using --yes changes mempalace init behavior to auto-accept detected entities (per CLI help). Since this doc is framed as a user-guided setup, consider keeping the default interactive command (mempalace init <dir>) and mentioning --yes as an option specifically for non-interactive/agent automation, with a brief note about the tradeoff (skips confirmation).
| Run `mempalace init --yes <dir>` where `<dir>` is the directory from Step 4. | |
| Run `mempalace init <dir>` where `<dir>` is the directory from Step 4. | |
| For non-interactive or agent-driven automation, you may use | |
| `mempalace init --yes <dir>` instead, but note that `--yes` skips | |
| confirmation and auto-accepts detected entities. |
There was a problem hiding this comment.
This file (instructions/init.md) is the MCP onboarding prompt — it's read by the AI agent during mempalace_status, not by humans. The agent runs mempalace init programmatically and hangs on the interactive prompt. --yes is the correct default here since the only consumer is an AI agent.
bensig
left a comment
bensig
left a comment
There was a problem hiding this comment.
Code review + security audit clean.
Upstream merged MemPalace#682-684 (our splits), MemPalace#687 (dry-run None room), MemPalace#695/MemPalace#708 (convo_miner full response), MemPalace#732 (0-chunk re-processing), plus VitePress docs site. Conflicts: - config.py: take upstream's [^\W_] regex (our MemPalace#683 merged version) - miner.py: integrate upstream's early-return for tiny files, dedupe dry-run read path - test_miner.py: keep our detect_room tests + upstream's dry-run test - CONTRIBUTING.md: take upstream's org URL update Co-Authored-By: Claude Opus 4.6 <[email protected]>
…ged, add MemPalace#681, bump test count to 715 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Summary
--yesflag tomempalace initininstructions/init.mdmempalace inithang on the interactive confirmation prompt —--yesskips itFiles changed
mempalace/instructions/init.md— line 44Test plan
mempalace init --yes <dir>completes without prompting🤖 Generated with Claude Code