chore: improve agent readiness score — AGENTS.md, dependabot, CODEOWNERS#497
chore: improve agent readiness score — AGENTS.md, dependabot, CODEOWNERS#497
Conversation
…abels - Add AGENTS.md with build commands, project structure, conventions - Add .github/dependabot.yml for automated pip + actions updates - Add .github/CODEOWNERS for review routing - Expand .gitignore (.env, .DS_Store, IDE configs, coverage, venvs) - Add C901 complexity rule to ruff (max-complexity=25, benchmarks excluded) - Add --durations=10 to pytest CI for test performance tracking - Add docs/schema.sql for knowledge graph schema documentation - Created P0-P3 priority + area/* + security/performance/docs labels
web3guru888
left a comment
web3guru888
left a comment
There was a problem hiding this comment.
AGENTS.md and the readiness batch look solid. A few observations from the integration side:
AGENTS.md is exactly what's been missing. The project structure table and "key files for common tasks" section are genuinely useful for contributors who want to orient before diving into code. We've pointed a few people at MemPalace recently and the first question is always "where does X live" — this answers it.
The coverage threshold discrepancy (85% in AGENTS.md, 80% in ci.yml / Windows path) is a minor inconsistency — AGENTS.md says 85%, the CI command is --cov-fail-under=80. Worth aligning so contributors aren't surprised when their 82% coverage PR passes CI but seems to violate the documented standard.
CODEOWNERS breadth: everything under integrations/ and the Claude/Codex plugin dirs routing to @bensig is a lot of ownership concentration. If community PRs in those areas stall waiting for review it could become a bottleneck. A [OPTIONAL] reviewer pattern or a broader @milla-jovovich backup for integrations might help throughput.
schema.sql is useful — having the KG schema in a readable file outside the Python code makes it much easier to validate against. One note: properties TEXT DEFAULT '{}' and the attributes table exist in parallel — the docs comment clarifying which one is the canonical way to attach metadata to an entity would save contributors a wrong-direction PR.
dependabot weekly cadence is right for a project of this pace. The open-pull-requests-limit: 5 for pip is fine but worth watching — ChromaDB version churn is already a major community pain point (#426, #445, #457, #458), and dependabot bumps can create merge conflicts on pyproject.toml pin lines if they land mid-PR.
Overall: this is a clean infra batch with no behavior changes. +1 to merge, the CI pass is the remaining gate.
3 participants
Summary
Batch of improvements targeting Factory Droid readiness criteria. Current score: 36% (Level 2). Expected after merge: ~50%+ (Level 3).
New files:
AGENTS.md— build commands, project structure, conventions (unlocks agents_md + agents_md_validation).github/dependabot.yml— automated dependency updates for pip + actions (unlocks dependency_update_automation).github/CODEOWNERS— review routing for core maintainers (unlocks codeowners)docs/schema.sql— knowledge graph schema extracted from code (unlocks database_schema)Updated files:
.gitignore— added .env, .DS_Store, IDE configs, coverage, venvs (unlocks gitignore_comprehensive)pyproject.toml— added C901 complexity rule (max 25, benchmarks excluded) (unlocks cyclomatic_complexity).github/workflows/ci.yml— added--durations=10to pytest (unlocks test_performance_tracking)Labels created: P0-P3 priority, area/mcp, area/mining, area/search, area/kg, area/cli, area/ci, security, performance, docs
Test plan
/readiness-reportafter merge to verify score improvement