PR Review: Increase test coverage and fix Windows encoding bugs

Executive Summary

Affected Areas: mcp_server.py, onboarding.py, version.py, pyproject.toml, plugin configs, 12 test files

Business Impact: Improves reliability on Windows, doubles coverage threshold (30% → 60%), reduces regression risk

Flow Changes: mcp_server.py now silently ignores unknown CLI args instead of erroring; onboarding.py explicitly writes UTF-8

Ratings

PR Health

• Has clear description
• References ticket/issue (if applicable) — no ticket referenced
• Appropriate size (justified — mostly tests)
• Has relevant tests
• "How to test" section is empty
• PR description claims "Adds github action pipeline" but no workflow file is included

High Priority Issues

🐛 #1: Incomplete Windows encoding fix — split_mega_files.py and entity_registry.py also lack encoding="utf-8"

Location: mempalace/split_mega_files.py and mempalace/entity_registry.py | Confidence: ✅ HIGH

This PR correctly fixes two write_text() calls in onboarding.py by adding encoding="utf-8", but the same bug exists in two other files. On Windows, the default encoding may be cp1252 or similar, causing UnicodeEncodeError when writing non-ASCII content (e.g. entity names with accents, or source files with Unicode).

mempalace/split_mega_files.py:

- out_path.write_text("".join(chunk))
+ out_path.write_text("".join(chunk), encoding="utf-8")

mempalace/entity_registry.py:

- self._path.write_text(json.dumps(self._data, indent=2))
+ self._path.write_text(json.dumps(self._data, indent=2), encoding="utf-8")

Medium Priority Issues

🏗️ #2: Missing CI pipeline file contradicts PR description

Location: PR description / .github/workflows/ | Confidence: ✅ HIGH

The PR body states "Adds github action pipeline for test coverage" but no .github/workflows/ file is present in the changeset. Either the pipeline file was forgotten, or the description is inaccurate.

🎨 #3: Version 3.0.12 skipped

Location: mempalace/version.py:3, pyproject.toml:3 | Confidence: ✅ HIGH

Version jumps from 3.0.11 → 3.0.13, skipping 3.0.12. If intentional (e.g. 3.0.12 was a failed/reverted release), no action needed. Otherwise, correct to 3.0.12.

⚠️ #4: parse_known_args silently swallows typos in CLI flags

Location: mempalace/mcp_server.py:47-48 | Confidence: ⚠️ MED

Changing parse_args() to parse_known_args() is a reasonable fix for IDE harnesses that pass extra flags, but it also means a typo like --palce (instead of --palace) is silently ignored rather than producing a helpful error. Consider logging the discarded args:

  args, _ = parser.parse_known_args()
+ if _:
+     logger.debug("Ignoring unknown args: %s", _)
  return args

Low Priority Issues

🎨 #5: hooks_cli.py also has write_text without encoding

Location: mempalace/hooks_cli.py — last_save_file.write_text(str(exchange_count)) | Confidence: ⚠️ MED

This call only writes a numeric string so encoding is unlikely to matter in practice, but for consistency with the Windows encoding fix pattern, adding encoding="utf-8" would be complete.

🎨 #6: Source and target branch are both main

Location: PR metadata | Confidence: ✅ HIGH

Both sourceBranch and targetBranch are main. This is an unusual PR configuration — typically a feature branch merges into main. Verify this is intentional.

Created by Octocode MCP https://octocode.ai

@bensig LGTM

@tmuskal @igorls conflicts