Skip to content

refactor: consolidate split known-names config loading#22

Merged
bensig merged 1 commit intoMemPalace:mainfrom
sheetsync:bugfix/split-known-names-loading
Apr 7, 2026
Merged

refactor: consolidate split known-names config loading#22
bensig merged 1 commit intoMemPalace:mainfrom
sheetsync:bugfix/split-known-names-loading

Conversation

@sheetsync
Copy link
Copy Markdown
Contributor

Summary

  • add a single cached loader for
  • derive known people and username mappings from that shared parsed config
  • add focused tests for missing, list-shaped, and dict-shaped configs plus people extraction behavior

Why

previously re-read and re-parsed the same config file in multiple helpers, which duplicated logic and made the utility harder to reason about.

Validation

  • source /Users/jamescane/git/mempalace/.venv/bin/activate
  • cd /Users/jamescane/git/mempalace-worktrees/split-known-names
  • PYTHONPATH=. pytest -q

igorls added a commit to igorls/mempalace that referenced this pull request Apr 7, 2026
- Enable WAL journal mode in _conn() for better concurrent read
  performance and reduced SQLITE_BUSY risk
- Add LIMIT 100 to entity-filtered timeline query (was unbounded,
  while global timeline already had LIMIT 100)

Findings: MemPalace#8 (HIGH — no WAL mode), MemPalace#22 (LOW — inconsistent limits)

Includes test infrastructure from PR MemPalace#131.
92 tests pass.
@bensig bensig merged commit 3068f75 into MemPalace:main Apr 7, 2026
igorls added a commit to igorls/mempalace that referenced this pull request Apr 7, 2026
- Enable WAL journal mode in _conn() for better concurrent read
  performance and reduced SQLITE_BUSY risk
- Add LIMIT 100 to entity-filtered timeline query (was unbounded,
  while global timeline already had LIMIT 100)

Findings: MemPalace#8 (HIGH — no WAL mode), MemPalace#22 (LOW — inconsistent limits)

Includes test infrastructure from PR MemPalace#131.
92 tests pass.
jphein added a commit to jphein/mempalace that referenced this pull request Apr 12, 2026
…t count 701

- README: mark MemPalace#635 as merged via MemPalace#667, fix cosine (not L2) distance
- CLAUDE.md: test count 692→701, drawer count 132K→134K, replace
  stale upstream PR list with current table, add fork change MemPalace#22
  (bensig's security/pagination/error reporting fixes from MemPalace#667)

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants