Skip to content

refactor: unify init onboarding prompt handling#18

Closed
sheetsync wants to merge 1 commit intoMemPalace:mainfrom
sheetsync:bugfix/init-onboarding-prompt-unification
Closed

refactor: unify init onboarding prompt handling#18
sheetsync wants to merge 1 commit intoMemPalace:mainfrom
sheetsync:bugfix/init-onboarding-prompt-unification

Conversation

@sheetsync
Copy link
Copy Markdown
Contributor

Summary

  • add shared prompt helpers for interactive and non-interactive CLI flows
  • make onboarding, entity confirmation, and room approval use the same safe prompt behavior
  • let run guided onboarding in interactive mode, with and overrides
  • add regression tests for EOF-safe prompts and init onboarding behavior

Why

The repo already had a guided onboarding flow, but it was orphaned from the main init path and still used duplicated raw prompt handling.

Validation

  • source /Users/jamescane/git/mempalace/.venv/bin/activate
  • cd /Users/jamescane/git/mempalace-worktrees/init-onboarding
  • PYTHONPATH=. pytest -q

@sheetsync
Copy link
Copy Markdown
Contributor Author

(Written by a human) Apologies for the PR spam. It's not really spam - I've had an agent review things and introduce small, granular PRs to tighten things up.

@bensig
Copy link
Copy Markdown
Collaborator

bensig commented Apr 7, 2026

Init prompt handling was addressed in #123 (--yes now skips all interactive prompts). Closing as overlap — thanks for the contribution!

@bensig bensig closed this Apr 7, 2026
jphein added a commit to jphein/mempalace that referenced this pull request Apr 21, 2026
…#1023 merged, MemPalace#673 rebased

- Bump fork-ahead section header to "after v3.3.2"
- Strike #11 (quarantine_stale_hnsw) and MemPalace#18 (PID file guard) as
  merged-into-upstream-via-v3.3.2, keep entries for traceability
- Add v3.3.2-shipped items to "Merged into upstream (post-v3.3.1)"
- Rebuild PR table: 10 merged / 7 open / 7 closed; add MemPalace#1024 row,
  reclassify MemPalace#681/MemPalace#1000/MemPalace#1023 as merged, note MemPalace#673 rebased 2026-04-21
- Annotate MemPalace#661 status with the GitHub review-state machine caveat
  (CHANGES_REQUESTED persists until reviewer dismisses, not owed)
- Bump test count 1063 → 1096 post-merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants