fix: room detection checks keywords against folder paths#145
Merged
Conversation
detect_room() now matches folder path parts against room keywords, not just the room name. Fixes docs/ files routing to general instead of documentation room — "docs" wasn't a substring of "documentation" but is now matched via the persisted keywords list. Found during end-to-end testing after merging #108 keyword persistence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect_room()now matches folder path parts against room keywords, not just the room name. Previously, files indocs/would route togeneralinstead ofdocumentationbecause"docs"is not a substring of"documentation".Now the keywords list (persisted in mempalace.yaml since #119) is checked during path matching:
docs/matches keyword"docs"→ routes to room"documentation".Found during end-to-end testing after merging the keyword persistence fix.
Test plan
ruff check ./ruff format --check .passpytest tests/ -v— 27/27 passmempalace init --yes+mempalace minecorrectly routesdocs/files todocumentationroom