fix: paginate closet_llm col.get (#1073)#1107
Merged
igorls merged 1 commit intoMemPalace:developfrom May 6, 2026
Merged
Conversation
sha2fiddy
requested review from
bensig,
igorls and
milla-jovovich
as code owners
4 tasks
sha2fiddy
force-pushed
the
fix/1073-closet-llm-paginate
branch
2 times, most recently
from
ecba48b to
18e52d3
Compare
Mirror the pagination pattern PR MemPalace#851 landed in miner.py:status(). A single drawers_col.get(limit=total, ...) on palaces larger than SQLite's SQLITE_MAX_VARIABLE_NUMBER (32766) crashes inside chromadb. Fetch drawers in batch_size=5000 chunks, stepping offset until the collection is drained. by_source aggregation semantics are preserved exactly — grouping, wing filter, meta capture all unchanged. Closes MemPalace#1073. Related: MemPalace#802, MemPalace#850, MemPalace#1016.
sha2fiddy
force-pushed
the
fix/1073-closet-llm-paginate
branch
from
18e52d3 to
db28bf1
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paginate regenerate_closets drawer fetch (batch_size=5000) to avoid SQLITE_MAX_VARIABLE_NUMBER crash on large palaces. Mirrors #851. Closes #1073.